Use TestContainers #1330
Merged
Use TestContainers #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
requested review from
DennisHeimbigner and
haileyajohnson
as code owners
haileyajohnson
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #1329 (had to reopen due to GitHub UI merge bug)
Description of Changes
The goal of this PR is to replace usage of remotetest and gretty in netcdf-java with TestContainers. The TestContainer uses docker to start/stop the dts and d4ts war files.
Additional notes:
Originally I tried to use a category for all tests that now need docker to be able to choose to exclude them. However, this did not work correctly with @parameterized tests, as these classes are still initialized even when the category would make them excluded. If they refer to the docker server in their static fields then they would fail to initialize due to docker not being present. So here I use the less nice solution of excluding the entire package of tests that need docker when -DskipDockerTests=True is given.
In the docker file, when I used the d4ts-5.4.war file there were some issues which were resolved with the 5.5-SNAPSHOT. That snapshot, however, will only be on nexus for a short while so we will have to update this in the next few weeks. Hopefully soon we can switch this to the 5.5 release.
For now we will have to exclude the docker tests on Jenkins using -DskipDockerTests=True